Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable to develop #2427

Merged
merged 16 commits into from
Jul 4, 2024
Merged

Merge stable to develop #2427

merged 16 commits into from
Jul 4, 2024

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

merge stable to develop

matrss and others added 16 commits May 27, 2024 10:40
Occasionally the test runs on macos-13 are super slow and there is
generally a lot of variation in the time required to run the test suite
on those runners. I think they genuinely need more time sometimes, so
this increases the timeout to accommodate.
* Run flake8 for all .py files tracked in git

* Fix flake8 errors
this should keep it archived also when a server sets the threshold to a few years
* Add a codespell lint job

* Fix misspellings found by codespell
* updated data base migration to current release

* deprecation for manual migration added
`rtd.io` is on longer operational, according to [the project page](https://readthedocs.org/projects/mss/) the correct domain is either `rtfd.io` or the full `readthedocs.io`. Also switch to https.
* Fixed an issue with units being ignored in vertical axis
* Fixed an issue with *assuming* that vertical axis is in pressure if no
  standard name "air_pressure" was available
* Fixed an issue with extrapolating data
* Fixes an issue with interpolating in pressure instead of log-pressure
* Fixes an issue with ignoring jumps/extrapolation in data for missing
  longitudes (now it is consistent with vertical section driver)
* doc updated

* indenting level fixed

* add details about the wsgi modules
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mixes a bunch of unrelated changes, which makes it basically impossible to review for correctness of the intention of each change when applied to develop.

It was stated in #2332 that these PRs shouldn't be reviewed for the correctness of the intention of each commit, but instead just for if they are technically applicable to the target branch. But since I only find the former worthwhile for a review (after all, the latter is already done automatically by git through merge conflicts) I won't review this, as also stated in #2332.

@ReimarBauer ReimarBauer requested a review from gisi90 July 4, 2024 13:38
Copy link
Contributor

@gisi90 gisi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes mostly typos

@ReimarBauer ReimarBauer merged commit 455718f into develop Jul 4, 2024
10 of 11 checks passed
@ReimarBauer ReimarBauer deleted the merge_stable_to_develop branch July 4, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants